Remove unused exception class. Closes #2102 #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmponos
requested changes
Dec 7, 2019
|
@gmponos not sure I see the need for a deprecation notice for a heretofore-unused exception. |
|
Anyway it does not matter anymore.. I think 6.5 will be the last version of v6 which was tagged yesterday. So this can be easily merged for v7. |
Nyholm
force-pushed
the
remove-seek-exception
branch
from
82b83d5
to
42113d5
Compare
|
Deprecation notices are the way to go, even if the class is never used. But master is not targeting 7.0 so no need for that (as @gmponos says). I've rebased your PR and waiting for the tests to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.