Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework the exceptions to be compatible with PSR-18 #2474

Merged
merged 6 commits into from
Dec 28, 2019
Merged

Rework the exceptions to be compatible with PSR-18 #2474

merged 6 commits into from
Dec 28, 2019

Conversation

gmponos
Copy link
Member

@gmponos gmponos commented Dec 18, 2019 •
edited
Loading

Why this is needed...?

  1. Previously we had this change applied

Problem with this is that the request is not actually invalid. The options are invalid. The request object is fine.

Since we have our own Guzzle InvalidArgumentException I suggest to use that one.

  1. Also we have places inside the handlers that we throw RequestExceptions (like here)

Let me know WDYT...

@gmponos gmponos changed the title Rework the exceptions to be better compatible with PSR-18 Rework the exceptions to be compatible with PSR-18 Dec 18, 2019
@gmponos gmponos added this to the 7.0.0 milestone Dec 18, 2019
@gmponos gmponos requested a review from Nyholm December 18, 2019 21:45
Nyholm
Nyholm approved these changes Dec 21, 2019
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes in this PR.

  1. I think those are valid request exceptions. They are exceptions that occur when processing the request.

@Nyholm Nyholm merged commit 4021a74 into guzzle:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gmponos @Nyholm