Method annotation is not enforcing return type argument #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagikazarmark
previously requested changes
Dec 24, 2019
gmponos
commented
Dec 28, 2019
| message: "#^Method GuzzleHttp\\\\Exception\\\\BadResponseException\\:\\:getResponse\\(\\) should return Psr\\\\Http\\\\Message\\\\ResponseInterface but returns Psr\\\\Http\\\\Message\\\\ResponseInterface\\|null\\.$#" | ||
| count: 1 | ||
| path: src/Exception/BadResponseException.php | ||
|
|
There was a problem hiding this comment.
I added this to baseline
IMHO it is a false positive.
There was a problem hiding this comment.
No it is not... phpstan only looks at the docblock.. and does not check the whole flow of the code in order to understand that the response can never be null...
There was a problem hiding this comment.
What if you add a docblock to the function then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the class is not final and can be extended the method annotation does not enforce the return type.