Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Avoid the getenv function when unsafe #2531

Merged
merged 8 commits into from
Jan 2, 2020
Merged

[7.x] Avoid the getenv function when unsafe #2531

merged 8 commits into from
Jan 2, 2020

Conversation

GrahamCampbell
Copy link
Member

This is the 7.x version of #2530.

gmponos
gmponos requested changes Dec 31, 2019
View reviewed changes
Copy link
Member

@gmponos gmponos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to update the UPGRADE guide and CHANGELOG.

@GrahamCampbell GrahamCampbell changed the title [7.x] Avoid the unsafe getenv function [7.x] Avoid the getenv function when unsafe Jan 2, 2020
@gmponos gmponos requested a review from Nyholm January 2, 2020 09:40
sagikazarmark
sagikazarmark approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@sagikazarmark sagikazarmark added this to the 7.0.0 milestone Jan 2, 2020
@sagikazarmark sagikazarmark merged commit 3cedbdf into guzzle:master Jan 2, 2020
@GrahamCampbell GrahamCampbell deleted the master-no-get-env branch January 2, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark sagikazarmark approved these changes

@gmponos gmponos gmponos approved these changes

@Nyholm Nyholm Awaiting requested review from Nyholm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GrahamCampbell @sagikazarmark @gmponos