-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CURLOPT_ENCODING not to be overwritten #2595
Conversation
This needs a rebase and a test. Also make sure CI is green |
Friendly ping |
Ping ping =) |
@YoakeSakura will you finish this PR? |
846bd64
to
988261f
Compare
Thanks for the ping, sorry for the delay. Incidentally, I think it's a good idea to add an option to automatically set the compression that cURL can support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair. So if you specify $options['curl'][\CURLOPT_ENCODING]
you dont want Guzzle to override it with data from the Accept-Encoding
heading.
Thank you |
This PR fixes an issue where CURLOPT_ENCODING is overwritten when decode_content is true (default is true).
Before this fix, setting only CURLOPT_ENCODING removes the Accept-Encoding header and the server response is not compressed.
After this fix, the Accept-Encoding header is sent and the server response is compressed.
Maybe this will solve that issue #2270