Dont show curl version in user agent #2654
Conversation
src/Utils.php
Outdated
| } | ||
|
|
||
| return $defaultAgent; | ||
| return 'GuzzleHttp/Guzzle'; |
There was a problem hiding this comment.
Should be GuzzleHttp only as the part behind the slash is specified as a version in the corresponding RFC.
There was a problem hiding this comment.
It doesn't matter too much, does it?
I named the guzzle 7 to "Guzzle", and now there is a version. =)
There was a problem hiding this comment.
Depends as always 😁. The RFC defines the version as a Token. And the agent is a token too. So it is may be conform but unexpected as the examples show numeric version strings.
But what the RFC clearly states is that the version part itself is optional.
There was a problem hiding this comment.
But what the RFC clearly states is that the version part itself is optional.
Okey, I've not read the RFC. Im happy to drop this.
Thank you
|
Maybe include the major version from the client interface as the version? |
Don't use any fancy user agent. There is no reason to tell the world about what CURL version you have installed. If a user finds this important, they can add it themselves.
This will fix #2635, fix #2642