Pass response to TooManyRedirectsException

[davidgrayston]

Fixed

• TooManyRedirectsException now has response

Note: #2589 includes additional breaking changes to ensure RequestException always has a response, which will be considered for version 8.0.0

If you'd prefer this fix to remain as part of #2589 I'll close this PR

[GrahamCampbell]

This PR extracts a non-breaking change from #2589, for 7.x. 👍

[gmponos]

Hi! I saw the comment from @Tobion ..

Looks like TooManyRedirectsException does not have a response but should have.

but I wonder.. when you have too-many-redirects.. it most probably mean you also have many-responses.. so which response out of these should be included to the exception? Why only the last one?

[davidgrayston]

The main reason I used the last response is because that's the one available when the exception is thrown. I suppose it gives some context to what's happening, but perhaps it isn't providing much value?

If this causes more confusion than it is helpful, and there's a decision not to make the response mandatory, perhaps this idea should be abandoned? (happy to close both PRs if that's the case?)

[gmponos]

I am open to the discussion as well.. let's leave this open.. It's just the reason why I am not 100% sure about this.

[Nyholm]

What is the status of this PR?

[GrahamCampbell]

I think it just needs to be rebased on master?

[Nyholm]

I think this looks good. Thank you