Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more strict with types #2914

Merged
merged 4 commits into from Jul 17, 2021
Merged

Be more strict with types #2914

merged 4 commits into from Jul 17, 2021

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 17, 2021

Make sure getMaxAge() always returns null or int. Also trigger deprecations if wrong types are passed to SetCookie

This will fix #2888

Make sure getMaxAge() always returns null or int. Also trigger deprecations if wrong types are passed to SetCookie
@Nyholm Nyholm requested a review from GrahamCampbell Jul 17, 2021
@GrahamCampbell
Copy link
Member

GrahamCampbell commented Jul 17, 2021

We should probably turn off the authoritative phpdoc types setting in phpstan (or whatever it's called).

@Nyholm
Copy link
Member Author

Nyholm commented Jul 17, 2021

Yeah... But I rather just add this to the baseline.

Note how I prepare the user and code for version 8.

@GrahamCampbell
Copy link
Member

GrahamCampbell commented Jul 17, 2021

Ok, sure. Re-gen the baseline then.

@Nyholm
Copy link
Member Author

Nyholm commented Jul 17, 2021

Baseline is updated and the CI is green.

Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

One tiny comment. Then good to merge.

composer.json Outdated Show resolved Hide resolved
@Nyholm Nyholm merged commit 1482295 into guzzle:master Jul 17, 2021
17 checks passed
@Nyholm Nyholm mentioned this pull request Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setExpires/getMaxAge: Notice: A non well formed numeric value encountered
2 participants