Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpdoc handle_factory array #2919

Merged
merged 2 commits into from Sep 5, 2021
Merged

Fix phpdoc handle_factory array #2919

merged 2 commits into from Sep 5, 2021

Conversation

BafS
Copy link
Contributor

@BafS BafS commented Jul 20, 2021

  • Array key should be handle_factory, not factory
  • Added @param array information

- Array key should be `handle_factory`, not `factory`
- Added @param array information
*
* @param array $options Array of options to use with the handler
* @param array{handle_factory?:CurlFactoryInterface} $options Array of options to use with the handler
Copy link
Member

@GrahamCampbell GrahamCampbell Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array{handle_factory?: ?CurlFactoryInterface} is probably the correct type, here.

Copy link
Contributor Author

@BafS BafS Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, about the space after the colon it would be great to consolidate around one convention, I did it like that because of

* @return array{0:string, 1:int, 2:?string, 3:array}

we may want to update the code there too

@GrahamCampbell GrahamCampbell merged commit 2d77dc5 into guzzle:master Sep 5, 2021
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants