Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail on php 5.3 #857

Closed
wants to merge 1 commit into from
Closed

fail on php 5.3 #857

wants to merge 1 commit into from

Conversation

dawehner
Copy link
Contributor

If a project like Drupal ships with vendor files you cannot validate the PHP versions and functions.php breaks, see https://www.drupal.org/node/2353509

@mtdowling
Copy link
Member

This is handled by composer when installing, and a PHP 5.4 requirement is stated in the docs. If you need a check for this in a specific application, then it should be added to the application (in this case, Drupal).

@mtdowling mtdowling closed this Oct 12, 2014
@dawehner
Copy link
Contributor Author

I would like to avoid checking in index.php
On Oct 12, 2014 8:10 AM, "Michael Dowling" notifications@github.com wrote:

This is handled by composer when installing, and a PHP 5.4 requirement is
stated in the docs. If you need a check for this in a specific application,
then it should be added to the application (in this case, Drupal).


Reply to this email directly or view it on GitHub
#857 (comment).

@dawehner
Copy link
Contributor Author

Can you make that include optional?
On Oct 12, 2014 8:17 AM, "daniel wehner" dawehner@googlemail.com wrote:

I would like to avoid checking in index.php
On Oct 12, 2014 8:10 AM, "Michael Dowling" notifications@github.com
wrote:

This is handled by composer when installing, and a PHP 5.4 requirement is
stated in the docs. If you need a check for this in a specific application,
then it should be added to the application (in this case, Drupal).


Reply to this email directly or view it on GitHub
#857 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants