Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

fix php version issue from ErrorResponsePlugin #16

Closed
wants to merge 1 commit into from

Conversation

sbutnariu
Copy link

The method used for verifying that a class implementes an interface (is_subclass_of) did not worked with interfaces before php 5.3.7

The method used before (is_subclass_of) did not worked with interfaces before php 5.3.7
@mtdowling
Copy link
Member

This is pretty heavy handed for simple validation. I wonder if the validation should just be removed instead?

@sbutnariu
Copy link
Author

If the validation is removed, users can use classes that don't implement static method 'fromCommand' , and an error will issue when calling this method at line 71

@mtdowling
Copy link
Member

Yeah, and either way the end-user runs into an error that they really can't recover from.

I think a better option would be to use is_callable() and not enforce the interface.

@mtdowling mtdowling closed this Apr 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants