This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
Remove unneeded reset() in ResourceIteratorTest #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fredemmott
commented
Apr 9, 2014
fredemmott
commented
- it's plain unneeded - foreach calls rewind() on the iterator anyway
- as it's not an ArrayIterator or array, it actually doesn't call rewind() - it resets the array pointer for the internal property list
- This is a known wontfix HHVM incompatibility
|
refs guzzle/guzzle#538 |
mtdowling
added a commit
that referenced
this pull request
Apr 9, 2014
Remove unneeded reset() in ResourceIteratorTest
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.