This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
Handle the fact that isFresh() may return null #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, but I'm going to close this since this repo has been EOL for a while now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this project is still being maintained, but I suspect guzzle3 is still the only choice out there for people using PHP v5.3.
The issue here is that
isFreshreturns either a boolean ornull, so checking forfalseis not sufficient. This causes guzzle to erroneously cache responses-- in my case we haveCache-Control: max-age=0andAge: 0being specified on responses, and guzzle is choosing to cache.