Allow Symfony3 Event-Dispatcher

[barryvdh]

As disussed on Twitter, @mtdowling would consider a non-breaking Symfony 3 PR.

This adds the deprecated methods back to the Guzzle events and adds the name/dispatcher to events emitted by Guzzle or the AbstractDispatcher.
Tests are run on 5.5+5.6 on both Symfony 2 and 3.

Test are currently failing because of Doctrine, but unrelated to this PR.

[GrahamCampbell]

👎

[GrahamCampbell]

Guzzle 3 is EOL.

[Nek-]

@GrahamCampbell nevermind, so much libraries use it and it's blocking. Please consider to merge a patch for the symfony dispatcher version.

[GrahamCampbell]

It's not up to me, but I'd say, don't merge it. It's EOL.

[lyrixx]

It's not up to me, but I'd say, don't merge it. It's EOL.

I totally disagree with you. I think you said that because you are not working on a project that use guzzle 3 and because you love things that are right / beautiful. But on some project, you may want to update to symfony 3 but you are blocked by guzzle that don't work with symfony 3.

This PR is quite small and will un-block so many people. I know it's EOL but please, be pragmatic and helpful here.

Thanks

[barryvdh]

Hmm, not sure what user land code is relying in the events, so can't guarantee 100% BC probably.

[videni]

I also need guzzle 3.0 to work with symfony 3

[Konafets]

Why you don't fork the repository, apply the patch and reference that in your project?

[teohhanhui]

Currently when using Symfony 3 and when using for example FOSHttpCacheBundle 1.x, guzzle/guzzle 3.8.1 is installed (because it's before #17).

Does it even work properly?

[barryvdh]

Does it even work properly?

Probably not

[teohhanhui]

There are probably still many other packages that have not been migrated to a current version of Guzzle... If there can be a fix here, it'd be great. (I know it's not ideal, and that it would encourage usage of an unmaintained old version.)