Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak #128

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Fix memory leak #128

merged 2 commits into from
Sep 21, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Sep 20, 2020

Make sure we dont have a reference to the closure in the exception stack trace.

fix guzzle/guzzle#2606
fix hyperf/hyperf#1486
fix #109

Nyholm added a commit to Nyholm/promises that referenced this pull request Sep 20, 2020
@GrahamCampbell
Copy link
Member

Heh, interesting. Good work. 👍

@limingxinleo
Copy link

👍🏻

@Nyholm
Copy link
Member Author

Nyholm commented Sep 21, 2020

Thank you for the reviews

@Nyholm Nyholm merged commit 8d7c8fb into guzzle:master Sep 21, 2020
@Nyholm Nyholm deleted the memory-leak branch September 21, 2020 06:06
Nyholm added a commit that referenced this pull request Sep 30, 2020
* Prepare for 1.4.0

* Added #128 in the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak when throw exception in Middleware::httpErrors(). [BUG] guzzle http内存溢出问题
3 participants