Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerRequest::fromGlobals header parsing is patchy #160

Closed
kael-shipman opened this issue Sep 13, 2017 · 1 comment
Closed

ServerRequest::fromGlobals header parsing is patchy #160

kael-shipman opened this issue Sep 13, 2017 · 1 comment

Comments

@kael-shipman
Copy link
Contributor

The getallheaders function doesn't seem to be very reliable, even on apache.
kael-shipman pushed a commit to kael-shipman/psr7 that referenced this issue Sep 13, 2017
Improved header parsing for ServerRequest::fromGlobals (fixes guzzl…
685b5a4 
…e#160)
@kael-shipman
Copy link
Contributor Author

This is a duplicate of #126. My bad.

kael-shipman added a commit to kael-shipman/psr7 that referenced this issue Dec 9, 2017
@kael-shipman
Reverted changes in favor of using new polyfill dependency and added …
ec88056 
…test (refs guzzle#160)
Tobion pushed a commit that referenced this issue Apr 23, 2018
@kael-shipman @Tobion
Improved header parsing for ServerRequest::fromGlobals (fixes #160) (…
aa3070a 
…#162)

* Improved header parsing for `ServerRequest::fromGlobals` (fixes #160)

* Added 'Content-Type' header considerations because of a PHP bug

* Fixed coding style issues

* Reverted changes in favor of using new polyfill dependency and added test (refs #160)

* Removed superfluous `if` statement for getallheaders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kael-shipman