-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in LazyOpenStream #428
Comments
Thanks for getting in touch. Which methods are missing, please? |
Sorry, I must correct myself, all methods are existing, I did miss the trait. Nevertheless, TYPO3 is extending the class, and the "final" is therefore disturbing. It might be possible though that the according implementation in TYPO3 should be changed. |
The according issue in TYPO3 can be found here if it's of interest: |
Typo3 should make another class that implements that interface and takes a stream into he constructor, and then proxies calls the calls it wants, and customizes the calls it doesn't wanna proxy. Composition over inheritance. :) |
Yes it's done just wrong in TYPO3 :) |
LazyOpenStream
defines only 2 methods ofPsr\Http\Message\StreamInterface
but is declared as final.psr7/src/LazyOpenStream.php
Line 13 in 148492f
As final class it neither includes all methods of the interface, nor allows to be extended to satisfy the interface,
The text was updated successfully, but these errors were encountered: