Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #212 #213

Closed
wants to merge 1 commit into from
Closed

fixes #212 #213

wants to merge 1 commit into from

Conversation

bkdotcom
Copy link

fromGlobals() : use static keyword

@bkdotcom
fixes guzzle#212
85b335b 
fromGlobals() : use static keyword
GrahamCampbell
GrahamCampbell requested changes Aug 27, 2018
View reviewed changes
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes the constructor of the parent has the same constructor, which is probably a breaking change.

@sagikazarmark
Copy link
Member

This has been rejected once. Please see #158 and #159 for explanations.

@Nyholm
Copy link
Member

Nyholm commented Aug 27, 2018

Thank you for this issue and PR. Though this has been discussed before I will close this PR.

@Nyholm Nyholm closed this Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkdotcom @sagikazarmark @Nyholm @GrahamCampbell