OpenStackFloatingIP in_use method doesn't return the correct result #42 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loudVE#42 The floating IP status was tests, and if found to be 'ACTIVE' True was returned. However, on our nectar cloud a newly created floating IP is set to 'ACTIVE' by default - even though it is not in use. This commit uses port id as indicator of being in use: if set, then the floating ip is attached, if not, it is not.
|
As with my other commits, when I run tox under python 3.5.1 in a virtualenv on my development machine against the nectar cloud, I get a few failures/errors: all due to the tests not expecting the underlying nectar infrastructure ("Bad router request: Incompatible network." and "publicURL endpoint for compute service in Tasmania region not found". These are totally different failures to the ones the build is reporting. I'm guessing that the test environment here has some other sort of issue? |
|
I've tested this locally for now and it's working as you described. Thanks for following through with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The floating IP status was tests, and if found to be 'ACTIVE' True was
returned. However, on our nectar cloud a newly created floating IP is
set to 'ACTIVE' by default - even though it is not in use.
This commit uses port id as indicator of being in use: if set, then
the floating ip is attached, if not, it is not.