Analytics: Remove unmaintained statistics; remove API usage

This commit does a couple of things at once:

- Removes damage and buff statistics from EVTCAnalytics. They were subtly broken (damage did not consider iff, buff simulation never got updated for extensions and stack ids). These statistics were originally planned to be used for our own HTML logs, but Elite Insights does those better. EVTCAnalytics still aims to provide basic data efficiently, but Elite Insights should be considered for more in-depth statistics.

- GW2API classes used only by Rotation Comparison EVTCAnalytics are moved to Rotation Comparison. This removes all library dependencies from EVTCAnalytics.

ArcdpsLogManager/ManagerForm.cs

@@ -42,7 +42,7 @@ public sealed class ManagerForm : Form
 		private LogFinder LogFinder { get; } = new LogFinder();
 
 		private LogAnalytics LogAnalytics { get; } =
-			new LogAnalytics(new EVTCParser(), new LogProcessor(), log => new LogAnalyzer(log, null));
+			new LogAnalytics(new EVTCParser(), new LogProcessor(), log => new LogAnalyzer(log));
 
 		private ApiProcessor ApiProcessor { get; }
 		private UploadProcessor UploadProcessor { get; }

EVTCAnalytics.Benchmark/Program.cs

@@ -2,17 +2,14 @@
 using System.Diagnostics;
 using System.IO;
 using System.Linq;
-using GW2Scratch.EVTCAnalytics.Parsed;
 using GW2Scratch.EVTCAnalytics.Processing;
-using GW2Scratch.EVTCAnalytics.Statistics;
 
 namespace GW2Scratch.EVTCAnalytics.Benchmark
 {
 	internal class Program
 	{
 		public static EVTCParser Parser { get; set; } = new EVTCParser();
 		public static LogProcessor Processor { get; set; } = new LogProcessor();
-		public static GW2ApiData ApiData { get; set; } = null;
 
 		public static void Main(string[] args)
 		{
@@ -50,11 +47,11 @@ public static void Main(string[] args)
 
 				GC.Collect();
 
-				MeasureTimes(filename, Parser, Processor, ApiData, Console.Out);
+				MeasureTimes(filename, Parser, Processor, Console.Out);
 			}
 		}
 
-		private static void MeasureTimes(string filename, EVTCParser parser, LogProcessor processor, GW2ApiData apiData, TextWriter outputWriter)
+		private static void MeasureTimes(string filename, EVTCParser parser, LogProcessor processor, TextWriter outputWriter)
 		{
 			var stopwatch = Stopwatch.StartNew();
 			var log = parser.ParseLog(filename);
@@ -67,7 +64,7 @@ private static void MeasureTimes(string filename, EVTCParser parser, LogProcesso
 			var processedTime = stopwatch.Elapsed;
 
 			stopwatch.Restart();
-			var analyzer = new LogAnalyzer(processedLog, apiData);
+			var analyzer = new LogAnalyzer(processedLog);
 			var result = analyzer.GetResult();
 			var duration = analyzer.GetEncounterDuration();
 			var mode = analyzer.GetMode();

EVTCAnalytics/EVTCAnalytics.csproj

@@ -8,9 +8,4 @@
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <LangVersion>latest</LangVersion>
   </PropertyGroup>
-  <ItemGroup>
-    <PackageReference Include="Newtonsoft.Json" Version="12.0.2" />
-    <PackageReference Include="RestSharp" Version="106.6.10" />
-    <PackageReference Include="RestSharp.Newtonsoft.Json" Version="1.5.1" />
-  </ItemGroup>
 </Project>