RoadSurfaceLayer - replace clone functions

gwaldron · Mar 11, 2024 · 278f62c · 278f62c
1 parent 1fb4bcd
commit 278f62c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/osgEarthProcedural/ImGui/TerrainEditGUI b/src/osgEarthProcedural/ImGui/TerrainEditGUI
@@ -138,7 +138,7 @@ namespace osgEarth
                 osg::ref_ptr<osg::Image>& out_landcover,
                 GeoExtent& out_extent)
             {
-                osg::ref_ptr<Feature> feature = osg::clone(in_feature, osg::CopyOp::DEEP_COPY_ALL);
+                osg::ref_ptr<Feature> feature = new Feature(*in_feature);
                 GeoPoint center = feature->getExtent().getCentroid();
                 center = center.toLocalTangentPlane();
                 feature->transform(center.getSRS());

diff --git a/src/osgEarthProcedural/RoadSurfaceLayer.cpp b/src/osgEarthProcedural/RoadSurfaceLayer.cpp
@@ -519,7 +519,8 @@ RoadSurfaceLayer::getFeatures(
 
         // Clone features onto the end of the output list.
         // We must always clone since osgEarth modifies the feature data
+        // TODO: check whether this is actually true
         for (auto& f : sublist)
-            output.push_back(osg::clone(f.get(), osg::CopyOp::DEEP_COPY_ALL));
+            output.push_back(new Feature(*f));
     }
 }
diff --git a/src/osgEarthSplat/RoadSurfaceLayer.cpp b/src/osgEarthSplat/RoadSurfaceLayer.cpp
@@ -518,7 +518,8 @@ RoadSurfaceLayer::getFeatures(
 
         // Clone features onto the end of the output list.
         // We must always clone since osgEarth modifies the feature data
+        // TODO: check whether this is true
         for (auto& f : sublist)
-            output.push_back(osg::clone(f.get(), osg::CopyOp::DEEP_COPY_ALL));
+            output.push_back(new Feature(*f));
     }
 }