Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: upgrading from osgEarth 2.x to osgEarth 3.x - hints #1481

Closed
remoe opened this issue Apr 7, 2020 · 6 comments
Closed

WIP: upgrading from osgEarth 2.x to osgEarth 3.x - hints #1481

remoe opened this issue Apr 7, 2020 · 6 comments
Assignees
Labels
request Someone asking for something
Milestone

Comments

@remoe
Copy link
Contributor

remoe commented Apr 7, 2020

  • some include paths are different (Symbology, Annotations, Features)
  • fast_map replaced with UnorderedMap
  • TerrainEffects removed.
  • getProfile() -> getTilingProfile()
  • MapNode::getOverlayDecorator removed (osgEarth::Util::findTopMostNodeOfType() ? )
  • new ImageLayer -> ImageLayer::create
  • ImageLayerOptions -> ImageLayer::Options (prevent forward declare :/ )
  • ModelLayerOption -> ModelLayer::Options
  • MapOptions -> Map::Options
  • MapNodeOptions -> MapNode::Options
  • MapFrame removed (66323ed#diff-d8a1d7c2f3a0882ff635d1e978abdc49)
  • LabelSource removed (bae24a5)
  • FeatureSourceFactory / OGRFeatureOptions removed ->OGRFeatureSource (osgearth_callouts sample)
  • Map::isGeocentric() ->MapNode::isGeocentric()
  • TerrainLayer -> TileLayer ( no getTileSource ) (Replace TerrainLayer with TileLayer/TileSourceImageLayer/TileSourceElevationLayer #1414)
  • GeometryCompilerOptions::useGPUScreenSpaceLines() removed
  • earth file: <sky> -> <sky_simple>
@gwaldron gwaldron added the request Someone asking for something label Apr 7, 2020
@gwaldron gwaldron added this to the 3.0 milestone Apr 7, 2020
@remoe
Copy link
Contributor Author

remoe commented Apr 7, 2020

osgearth_pagingtest
osgearth_sharedlayer
osgearth_featuretiler

Are removed from build (CMake), why? They doesn't compile with 3.0.

can't find this includes:

  • osgEarthDrivers/feature_ogr/OGRFeatureOptions
  • osgEarthDrivers/model_feature_geom/FeatureGeomModelOptions

@remoe
Copy link
Contributor Author

remoe commented Apr 7, 2020

Can't find an alternative for GeometryCompilerOptions::useGPUScreenSpaceLines(). Is it not needed in 3.0?

@remoe
Copy link
Contributor Author

remoe commented Apr 8, 2020

Does anyone know why it could throw this error:

[osgEarth]* [ShaderLoader] Inline source for "RexEngine.Morphing.vert.glsl" is empty, and no external file could be found.
[osgEarth]* [ShaderLoader] Failed to load shader source from "RexEngine.Morphing.vert.glsl"

UPDATE: fixed 420e981

@remoe remoe changed the title WIP: upgrading from osgEarth 2.x to osgEarth 3.x - some missed issues WIP: upgrading from osgEarth 2.x to osgEarth 3.x - some small hints Apr 8, 2020
@plevy
Copy link
Collaborator

plevy commented Apr 8, 2020

Remo, Glenn fixed the "RexEngine.Morphing.vert.glsl" issue earlier today

@remoe remoe changed the title WIP: upgrading from osgEarth 2.x to osgEarth 3.x - some small hints WIP: upgrading from osgEarth 2.x to osgEarth 3.x - hints Apr 14, 2020
@remoe
Copy link
Contributor Author

remoe commented Apr 15, 2020

How one can convert this earth file fragment to osgEarth 3.0 ?

<sky driver="simple" hours="12.0" ambient="0.3"/>

UPDATE: #1491
2. UPDATE: need to write:

<sky_simple hours="12.0" ambient="0.3"/>

@Himbeertoni
Copy link

  • The color filters (Gamma, RGB, BrightnessContrast) for the image layers are gone in 3.0
  • I had to call osgEarth::MapNode::open() after creating the osgEarth::Map, otherwise osgEarth::MapNode::getTerrainEngine() would return a nullptr. Apparently this was done internally in versions prior to 3.0?
  • I had to add ${CMAKE_CURRENT_BINARY_DIR}/build/build_include to the list of osgEarth include directories, due to the new BuildConfig.h

@remoe remoe closed this as completed Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Someone asking for something
Projects
None yet
Development

No branches or pull requests

4 participants