Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci tests #8

Merged
merged 5 commits into from
May 13, 2024
Merged

Add ci tests #8

merged 5 commits into from
May 13, 2024

Conversation

mj-will
Copy link
Contributor

@mj-will mj-will commented May 8, 2024

Add CI.

This replaces #6 which was made from my fork and will hopefully trigger the CI

@WuShichao WuShichao self-requested a review May 12, 2024 20:04
Copy link
Collaborator

@WuShichao WuShichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, I have read that page https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks But I didn't find any "Workflow(s) awaiting approval":
image

@WuShichao WuShichao added the enhancement New feature or request label May 12, 2024
@WuShichao WuShichao mentioned this pull request May 12, 2024
@mj-will
Copy link
Contributor Author

mj-will commented May 13, 2024

Thanks @WuShichao, we may have to merge this to get the CI running for the first time. Hopefully it works, but if it doesn't, I can quickly put in a patch to fix it.

@mj-will mj-will added the CI label May 13, 2024
@WuShichao WuShichao merged commit f981313 into main May 13, 2024
@mj-will mj-will deleted the add-ci-tests branch May 13, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants