Skip to content

Commit

Permalink
Fix a hidden but kind of big bug that has been hiding for a while.
Browse files Browse the repository at this point in the history
  • Loading branch information
gwax committed Jul 1, 2016
1 parent d31fd10 commit 591ef22
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,12 @@ Acknowledgments
Changelog
=========

1.3.1
=====

- Fix bug where were were never actually reading set names from xlsx
files.

1.3.0
-----

Expand Down
2 changes: 1 addition & 1 deletion mtg_ssm/serialization/xlsx.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def counts_from_sheet(sheet):
header = [cell.value for cell in next(rows)]
for row in rows:
row_values = [cell.value for cell in row]
yield dict(zip(header, row_values))
yield dict(zip(header, row_values), set=sheet.title)


class XlsxDialect(interface.SerializationDialect):
Expand Down
2 changes: 1 addition & 1 deletion mtg_ssm/version.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
"""Version information."""
__version__ = '1.3.0'
__version__ = '1.3.1'
2 changes: 1 addition & 1 deletion tests/serialization/test_xlsx.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def test_counts_from_sheet():
sheet.append([1, 'B', '=5+7'])
rows = xlsx.counts_from_sheet(sheet)
assert list(rows) == [
{'A': 1, 'B': 'B', 'C': '=5+7'},
{'set': 'Sheet', 'A': 1, 'B': 'B', 'C': '=5+7'},
]


Expand Down

0 comments on commit 591ef22

Please sign in to comment.