Skip to content

Commit

Permalink
A number of Scryfall update fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
gwax committed Mar 11, 2023
1 parent b54f952 commit b36e968
Show file tree
Hide file tree
Showing 13 changed files with 702 additions and 644 deletions.
3 changes: 3 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,9 @@ Changelog
Development
-----------

- Fix a bunch of tests for scryfall data changes, which change a number of
promo set card assignments.
- Add "minigame" to scryfall set type.
- Improved scryfall caching performance and decreased cache folder size
by moving to requests-cache from manual caching.
- Huge scryfall read performance improvements by converting deserialization
Expand Down
1 change: 1 addition & 0 deletions mtg_ssm/scryfall/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ class ScrySetType(str, Enum):
MEMORABILIA = "memorabilia"
ALCHEMY = "alchemy"
ARSENAL = "arsenal"
MINIGAME = "minigame"


class ScryCardLayout(str, Enum):
Expand Down
6 changes: 5 additions & 1 deletion mtg_ssm/ssm.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,11 @@ def get_args(args: Optional[List[str]] = None) -> argparse.Namespace:
help="Treat set promos as a separate set/tab",
)

default_exclude_set_types = {ScrySetType.MEMORABILIA, ScrySetType.TOKEN}
default_exclude_set_types = {
ScrySetType.MEMORABILIA,
ScrySetType.TOKEN,
ScrySetType.MINIGAME,
}
parser.add_argument(
"--exclude-set-types",
default=",".join(default_exclude_set_types),
Expand Down
4 changes: 2 additions & 2 deletions tests/data/bulk_data.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"type": "default_cards",
"name": "Default Cards",
"description": "A JSON file containing every card object on Scryfall in English or the printed language if the card is only available in one language.",
"download_uri": "https://data.scryfall.io/default-cards/default-cards-20230227220950.json",
"updated_at": "2023-02-27T22:09:50.254000Z",
"download_uri": "https://data.scryfall.io/default-cards/default-cards-20230310220757.json",
"updated_at": "2023-03-10T22:07:57.155000Z",
"content_type": "application/json",
"content_encoding": "gzip"
}
Expand Down
Loading

0 comments on commit b36e968

Please sign in to comment.