Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure on build of new sheet - no support for Oathbreaker legality #33

Closed
plagueofgophers opened this issue Mar 17, 2023 · 1 comment
Closed

Comments

@plagueofgophers
Copy link

First time user, attempted to build a spreadsheet and it failed with an invalid enum in legalities:

Reading data from scryfall
Fetched https://api.scryfall.com/bulk-data
Fetched https://api.scryfall.com/sets
Fetched https://api.scryfall.com/migrations
Fetched https://api.scryfall.com/migrations?page=2
Fetched https://data.scryfall.io/default-cards/default-cards-20230316210924.json
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Python311\Scripts\mtg-ssm.exe\__main__.py", line 7, in <module>
  File "C:\Python311\Lib\site-packages\mtg_ssm\ssm.py", line 290, in main
    oracle = get_oracle(
             ^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\mtg_ssm\ssm.py", line 195, in get_oracle
    scrydata = fetcher.scryfetch()
               ^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\mtg_ssm\scryfall\fetcher.py", line 77, in scryfetch
    cards_data = msgspec.json.decode(
                 ^^^^^^^^^^^^^^^^^^^^
msgspec.ValidationError: Invalid enum value 'oathbreaker' - at `key` in `$[0].legalities`

Apparently a new format was endorsed by WOTC. Seems to be fixed by adding Oathbreaker to models.py

@gwax
Copy link
Owner

gwax commented Jul 13, 2023

This should be resolved by #45 now and released as version 2.6.2

@gwax gwax closed this as completed Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants