Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding proper support for python2.x version of ConfigParser #103

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

alurban
Copy link
Member

@alurban alurban commented Aug 2, 2018

This PR adds proper support for ConfigParser, the native python2 configuration parser. It solves a version issue by creating a dictionary of section parameters if a call to configparser[section] fails.

Test output is here (requires LIGO.ORG credentials): https://ldas-jobs.ligo-la.caltech.edu/~aurban/wdq/L1_1172489783.07/

This fixes #100.

@alurban alurban self-assigned this Aug 2, 2018
@alurban alurban requested a review from areeda August 2, 2018 23:14
@coveralls
Copy link

coveralls commented Aug 2, 2018

Pull Request Test Coverage Report for Build 250

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
gwdetchar/omega/config.py 0 1 0.0%
Totals Coverage Status
Change from base Build 248: 0.0%
Covered Lines: 428
Relevant Lines: 1070

💛 - Coveralls

@alurban alurban merged commit ececec2 into gwdetchar:master Aug 2, 2018
@alurban alurban deleted the python3-issues branch August 2, 2018 23:24
@alurban alurban added this to Done in O3 Omega Scans Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

configparser needs to be declared a dependence
2 participants