Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get channel units for outlier removal #104

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

macedo22
Copy link
Contributor

@macedo22 macedo22 commented Aug 7, 2018

When running gwdetchar-lasso-correlation, I found that some channels' TimeSeries.value held an array of floats, while others held an array of astropy quantity objects (astropy.units.Quantity). This change ensures that, when performing outlier removal, any possible Quantity units are preserved so that they can be successfully reassigned with their spline values.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 252

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.0%

Totals Coverage Status
Change from base Build 251: 0.0%
Covered Lines: 428
Relevant Lines: 1070

💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 252

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.0%

Totals Coverage Status
Change from base Build 251: 0.0%
Covered Lines: 428
Relevant Lines: 1070

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 252

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.0%

Totals Coverage Status
Change from base Build 251: 0.0%
Covered Lines: 428
Relevant Lines: 1070

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 252

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.0%

Totals Coverage Status
Change from base Build 251: 0.0%
Covered Lines: 428
Relevant Lines: 1070

💛 - Coveralls

@duncanmmacleod duncanmmacleod self-requested a review August 7, 2018 09:55
Copy link
Member

@duncanmmacleod duncanmmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duncanmmacleod duncanmmacleod self-assigned this Aug 7, 2018
@duncanmmacleod duncanmmacleod merged commit 026c367 into gwdetchar:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants