Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the data duration read in from frames #152

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Reduce the data duration read in from frames #152

merged 1 commit into from
Oct 1, 2018

Conversation

alurban
Copy link
Member

@alurban alurban commented Sep 29, 2018

Now that we require gwpy-0.12+, we should only read in as much data per channel as is requested by the user. This fixes #151.

@alurban alurban added this to In progress in Stabilize gwdetchar-omega via automation Sep 29, 2018
@alurban alurban added this to In progress in O3 Omega Scans via automation Sep 29, 2018
@coveralls
Copy link

coveralls commented Sep 29, 2018 •
edited

Coverage Status

Coverage remained the same at 37.445% when pulling 8a99a19 on alurban:reduce-duration into 52fb0f4 on gwdetchar:master.

@alurban alurban requested a review from a team October 1, 2018 16:42
duncanmmacleod
duncanmmacleod approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@duncanmmacleod duncanmmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alurban
Copy link
Member Author

alurban commented Oct 1, 2018

thanks @duncanmmacleod

@alurban alurban merged commit 93a0704 into gwdetchar:master Oct 1, 2018
Stabilize gwdetchar-omega automation moved this from In progress to Done Oct 1, 2018
O3 Omega Scans automation moved this from In progress to Done Oct 1, 2018
@alurban alurban deleted the reduce-duration branch October 1, 2018 16:48
@alurban alurban mentioned this pull request Oct 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanmmacleod duncanmmacleod duncanmmacleod approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
O3 Omega Scans
  
Done
Stabilize gwdetchar-omega
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Omega scans should grab only as much data as is requested
3 participants
@alurban @coveralls @duncanmmacleod