Support omega scan sub-blocks #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alurban
force-pushed
the
allow-block-parents
branch
6 times, most recently
from
086285a
to
af7ff53
Compare
|
@duncanmmacleod, after merging #158 I rebased this branch against master. Somewhat surprisingly, there were no merge conflicts, so this PR is ready for review. |
alurban
force-pushed
the
allow-block-parents
branch
3 times, most recently
from
d3e40d1
to
1c3e9ea
Compare
…tual channel blocks to have sub-blocks with different analysis attributes. (Note, this commit also ensures that the list of analyzed channels is built from the bottom up, rather than from the top down.)
alurban
force-pushed
the
allow-block-parents
branch
from
1c3e9ea
to
232be2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two substantive changes:
parentOmega scan INI kwarg, which allows contextual channel blocks with different analysis attributes to be linked to each other so that they are analyzed separately, but appear in one block together on the output page.Here is an example output page which places
L1:GDS-CALIB_STRAINandL1:CAL-DELTAL_EXTERNAL_DQin the same contextual block on the output page (requiresLIGO.ORGcredentials). These channels have different frame types, so I used theparentargument to configure them to appear together.This fixes #146.