Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. formatting enhancements for omega scans #260

Merged
merged 10 commits into from
Mar 12, 2019
Merged

Misc. formatting enhancements for omega scans #260

merged 10 commits into from
Mar 12, 2019

Conversation

alurban
Copy link
Member

@alurban alurban commented Mar 11, 2019 •
edited
Loading

This PR implements miscellaneous formatting enhancements for omega scans, including:

  • Use the format builtin for string formatting in gwdetchar-omega and gwdetchar-omega-batch
  • Move a print statement out of gwdetchar.omega.scan and into gwdetchar-omega in anticipation of using the logger utility
  • Remove --verbose flag from gwdetchar-omega and gwdetchar-omega-batch, as it's rarely used to do anything useful

cc @duncanmmacleod

@alurban alurban added this to the 0.3.0 milestone Mar 11, 2019
@alurban alurban self-assigned this Mar 11, 2019
@alurban alurban added this to In progress in O3 Omega Scans via automation Mar 11, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.502% when pulling 6d82486 on alurban:condor-checkpoint into 976bf1d on gwdetchar:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.502% when pulling 6d82486 on alurban:condor-checkpoint into 976bf1d on gwdetchar:master.

@coveralls
Copy link

coveralls commented Mar 11, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 95.546% when pulling c0b90aa on alurban:condor-checkpoint into bb6fd5f on gwdetchar:master.

@alurban alurban changed the title WIP: Condor checkpointing for omega scans Misc. formatting enhancements for omega scans Mar 12, 2019
duncanmmacleod
duncanmmacleod approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@duncanmmacleod duncanmmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alurban alurban merged commit 9e0e573 into gwdetchar:master Mar 12, 2019
O3 Omega Scans automation moved this from In progress to Done Mar 12, 2019
@alurban alurban deleted the condor-checkpoint branch March 12, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanmmacleod duncanmmacleod duncanmmacleod approved these changes

Assignees

@alurban alurban

Labels
enhancement feature-request omega scans
Projects
O3 Omega Scans
  
Done
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alurban @coveralls @duncanmmacleod