Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fancybox constructors upstream for wider use #262

Merged
merged 8 commits into from
Mar 12, 2019

Conversation

alurban
Copy link
Member

@alurban alurban commented Mar 11, 2019

This PR moves the FancyPlot class and various link constructor utilities upstream to the gwdetchar.io.html module, and uses this to render image HTML on all output pages.

Quick things to note:

  • For Lasso in particular, these changes greatly simplify html construction for plots, as the function calls do all the heavy lifting
  • This was motivated in part by Lasso's use case being similar to omega scans' (and to hveto's, which will soon import its HTML constructors from gwdetchar)
  • The fancybox pop-up functionality is not implemented here, because it involves custom javascript and CSS stylesheets that must be processed at runtime; this is being handled separately by @duncanmmacleod

Test output of affected tools is available below, all made in an environment with python-2.7:

Tool Output
gwdetchar-lasso-correlation Link
gwdetchar-overflow Link
gwdetchar-software-saturations Link
gwdetchar-scattering Link

This is also the first PR to start to address #84.

cc @duncanmmacleod, @macedo22, @uberpye, @jrsmith02

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 95.499% when pulling e70d60c on alurban:move-fancyplot into 976bf1d on gwdetchar:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 95.499% when pulling e70d60c on alurban:move-fancyplot into 976bf1d on gwdetchar:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 95.499% when pulling e70d60c on alurban:move-fancyplot into 976bf1d on gwdetchar:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 95.499% when pulling e70d60c on alurban:move-fancyplot into 976bf1d on gwdetchar:master.

@coveralls
Copy link

coveralls commented Mar 12, 2019

Coverage Status

Coverage decreased (-0.003%) to 95.499% when pulling 45fbe40 on alurban:move-fancyplot into bb6fd5f on gwdetchar:master.

@alurban alurban changed the title WIP: Move fancyplots upstream Move fancyplots upstream for wider use Mar 12, 2019
@alurban alurban changed the title Move fancyplots upstream for wider use Move fancy boxconstructors upstream for wider use Mar 12, 2019
@alurban alurban changed the title Move fancy boxconstructors upstream for wider use Move fancybox constructors upstream for wider use Mar 12, 2019
@jrsmith02
Copy link
Contributor

This all sounds good to me, and the output pages all look good to me. Thanks @alurban !

Copy link
Member

@duncanmmacleod duncanmmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alurban alurban self-assigned this Mar 12, 2019
@alurban alurban merged commit 592ebd2 into gwdetchar:master Mar 12, 2019
@alurban alurban deleted the move-fancyplot branch March 12, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants