Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to footer style #289

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Remove references to footer style #289

merged 3 commits into from
Apr 2, 2019

Conversation

alurban
Copy link
Member

@alurban alurban commented Apr 1, 2019

This PR removes references to style from gwdetchar.io.html.write_footer. It is related to gwpy/gwsumm#241 and duncanmmacleod/bootstrap-ligo#2.

cc @duncanmmacleod

@alurban alurban added this to the 0.4.1 milestone Apr 1, 2019
@alurban alurban self-assigned this Apr 1, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.331% when pulling f43779e on alurban:footer-no-style into 82a057d on gwdetchar:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.331% when pulling f43779e on alurban:footer-no-style into 82a057d on gwdetchar:master.

@coveralls
Copy link

coveralls commented Apr 1, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 95.331% when pulling f660577 on alurban:footer-no-style into 82a057d on gwdetchar:master.

duncanmmacleod
duncanmmacleod approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@duncanmmacleod duncanmmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we bump the bootstrap-ligo submodule pin in a PR?

@alurban
Copy link
Member Author

alurban commented Apr 2, 2019

@duncanmmacleod, I was able to update bootstrap-ligo as follows:

$ cd bootstrap-ligo
$ git checkout master && git pull
$ cd ..
$ git add bootstrap-ligo
$ git commit -m ...

@alurban alurban merged commit 9baa9d5 into gwdetchar:master Apr 2, 2019
@alurban alurban deleted the footer-no-style branch April 2, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanmmacleod duncanmmacleod duncanmmacleod approved these changes

Assignees

@alurban alurban

Labels
enhancement html
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alurban @coveralls @duncanmmacleod