-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More scattering upgrades #301
Conversation
cf014e2
to
b70b77f
Compare
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 95.67% 95.67% +0.01%
==========================================
Files 23 23
Lines 1569 1571 +2
==========================================
+ Hits 1501 1503 +2
Misses 68 68
Continue to review full report at Codecov.
|
0575566
to
1b51d48
Compare
1b51d48
to
7fc0ec3
Compare
@duncanmmacleod, now that #298 is merged, this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR implements a few more scattering code upgrades:
An example run analyzing Livingston data from 2019-04-05 is available here (requires
LIGO.ORG
credentials).Since these changes depend on the new
gwdetchar.scattering
module, I'm marking this a work-in-progress until #298 is merged.This is related to #84 and #296.
cc @duncanmmacleod, @siddharth101, @jrsmith02, @andrew-lundgren