Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More scattering upgrades #301

Merged
merged 7 commits into from
Apr 16, 2019
Merged

Conversation

alurban
Copy link
Member

@alurban alurban commented Apr 11, 2019

This PR implements a few more scattering code upgrades:

  • Include more longitudinal-motion OSEMs in the default channel list
  • Do not display channels without evidence for scattering on the output page (but still plot them)
  • Handle the use case where no evidence of scattering is found in non-empty observing segments
  • Provide figure captions for scattering plots
  • Include Omicron trigger central frequency and SNR in the scattering summary

An example run analyzing Livingston data from 2019-04-05 is available here (requires LIGO.ORG credentials).

Since these changes depend on the new gwdetchar.scattering module, I'm marking this a work-in-progress until #298 is merged.

This is related to #84 and #296.

cc @duncanmmacleod, @siddharth101, @jrsmith02, @andrew-lundgren

@alurban alurban added this to the 0.5.0 milestone Apr 11, 2019
@alurban alurban self-assigned this Apr 11, 2019
@coveralls
Copy link

coveralls commented Apr 11, 2019

Coverage Status

Coverage increased (+0.1%) to 95.636% when pulling cf014e2 on alurban:scattering-channels into fd8de27 on gwdetchar:master.

@alurban alurban force-pushed the scattering-channels branch 4 times, most recently from cf014e2 to b70b77f Compare April 12, 2019 16:12
@codecov-io
Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #301 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   95.67%   95.67%   +0.01%     
==========================================
  Files          23       23              
  Lines        1569     1571       +2     
==========================================
+ Hits         1501     1503       +2     
  Misses         68       68
Flag Coverage Δ
#Linux 95.67% <100%> (+0.01%) ⬆️
#python27 95.35% <100%> (+0.01%) ⬆️
#python35 94.84% <100%> (+0.01%) ⬆️
#python36 94.97% <100%> (+0.01%) ⬆️
#python37 94.91% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
gwdetchar/scattering/core.py 100% <ø> (ø) ⬆️
gwdetchar/scattering/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7eb207...afea6a7. Read the comment docs.

@alurban alurban force-pushed the scattering-channels branch 2 times, most recently from 0575566 to 1b51d48 Compare April 15, 2019 13:59
@alurban alurban changed the title WIP: More scattering upgrades More scattering upgrades Apr 15, 2019
@alurban
Copy link
Member Author

alurban commented Apr 15, 2019

@duncanmmacleod, now that #298 is merged, this PR is ready for review.

Copy link
Member

@duncanmmacleod duncanmmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alurban alurban merged commit 0ab90a2 into gwdetchar:master Apr 16, 2019
@alurban alurban deleted the scattering-channels branch April 16, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants