New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML navigation bars #304
HTML navigation bars #304
Conversation
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
- Coverage 95.53% 94.71% -0.82%
==========================================
Files 21 21
Lines 1522 1569 +47
==========================================
+ Hits 1454 1486 +32
- Misses 68 83 +15
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
- Coverage 95.53% 94.71% -0.82%
==========================================
Files 21 21
Lines 1522 1569 +47
==========================================
+ Hits 1454 1486 +32
- Misses 68 83 +15
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 95.67% 95.69% +0.03%
==========================================
Files 23 21 -2
Lines 1569 1579 +10
==========================================
+ Hits 1501 1511 +10
Misses 68 68
Continue to review full report at Codecov.
|
64e4e1f
to
1a2700c
Compare
4165aa5
to
b71428c
Compare
@alurban, how do the new scattering, overflow, and software-saturations pages look when embedded inside the summary pages? |
@duncanmmacleod, in this example, the scattering navbar overtakes the summary page navbar. I think we can handle this in the summary page config files downstream, I'll look into it after lunch. |
@duncanmmacleod, I was right, you can remove the header and footer sections using a fancy regular expression in javascript: var x = data.indexOf('<body');
x = data.indexOf('>', x);
var y = data.lastIndexOf('</body>');
var content = data.slice(x+1, y);
content = content.replace(/(<header.[^]*header>)/g, "");
content = content.replace(/(<footer.[^]*footer>)/g, ""); The summary pages will then wrap their own navbar and footer around this, as the same example linked to above will show. tl;dr: we're in the clear as far as the summary pages are concerned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change, otherwise, looks good. And good work on figuring out the javascript for the summary page embedding.
Give each script's output a navbar Inherited SCSS from the summary pages Tighten the screws on navbar construction Unit tests for all navbar utilities Name the process in the navbar brand Put links on the upper-right corner, for all output pages
Thanks @duncanmmacleod, I've addressed your review comments above, when build tests pass I'll merge and put out a release as we discussed on this morning's call. |
As discussed on a call this morning, once I make these simple changes, I have permission to merge
This PR introduces a general-purpose bootstrap navbar constructor, originally designed for
gwsumm
. The following changes are included:gwdetchar.io.html.navbar
Test output is available here (all require
LIGO.ORG
credentials):gwdetchar-omega
gwdetchar-scattering
gwdetchar-overflow
gwdetchar-software-saturations
gwdetchar-lasso-correlation
This fixes #288.
cc @duncanmmacleod