Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scatter plots for range and blrms #72

Merged
merged 3 commits into from
Aug 7, 2018

Conversation

macedo22
Copy link
Contributor

Hi Duncan,

I added to the file code that generates two scatter plots for each auxiliary channel: 1) channel vs strain and 2) channel vs range. When I run this, it generates an HTML page output like so (https://ldas-jobs.ligo-la.caltech.edu/~alexandra.macedo/detchar/O1/L1-slow-correlation-1133906417-7199/), where the two scatter plots have been added below the other plots for each channel.

Disclaimers: With your last commit, c05f107 (c05f107#diff-c611d65ec72daf5387046f33ba3faed8), and its changes to gwdetchar-slow-correlation, I am unable to run gwdetchar-slow-correlation with the virtual environment install via these instructions that you and Dr. Smith provided (https://wiki.ligo.org/viewauth/DetChar/O1NoiseBreathing). In order to run gwdetchar-slow-correlation at all, it only works if I source detchar's install of gwpysoft and point to my own code with your last commit reverted (meaning, I undid the 2 changes you made to gwdetchar-slow-correlation that were made in commit c05f107). However, it seems you may be working on a new module, nds2, so after I got my code to work with the commit reverted, I replaced the lines to reflect your latest commit so that it is consistent with what you are currently working on. Please refer to the CSUF slack thread for the command that generates the error and the error message, itself, when I try to run gwdetchar-slow-correlation with the virtual environment's install of gwpysoft.

@coveralls
Copy link

coveralls commented Dec 21, 2017

Coverage Status

Coverage remained the same at 7.957% when pulling 2a40e7c on macedo22:scatter-plots into 15a64f9 on ligovirgo:master.

@duncanmmacleod
Copy link
Member

@macedo22, apologies this has lingered for this long, is it still ready to go?

@macedo22
Copy link
Contributor Author

@duncanmmacleod it works fine as-is, but I think I will clean it up a bit first and push a new commit in the near future. I will notify you when I do

@duncanmmacleod
Copy link
Member

@macedo22, bump.

@coveralls
Copy link

coveralls commented Aug 7, 2018

Pull Request Test Coverage Report for Build 255

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 40.0%

Files with Coverage Reduction New Missed Lines %
gwdetchar/tests/test_cds.py 2 100.0%
gwdetchar/tests/test_const.py 2 100.0%
gwdetchar/tests/test_daq.py 2 100.0%
gwdetchar/tests/test_cli.py 2 81.13%
Totals Coverage Status
Change from base Build 253: 0.0%
Covered Lines: 428
Relevant Lines: 1070

💛 - Coveralls

@macedo22
Copy link
Contributor Author

macedo22 commented Aug 7, 2018

@duncanmmacleod, should be good to go now. Here is a very short sample output page so you can see the scatter plots in the drop down tabs: https://ldas-jobs.ligo-la.caltech.edu/~alexandra.macedo/detchar/O1/slow-corr-scatter/

@duncanmmacleod duncanmmacleod merged commit 64b36d3 into gwdetchar:master Aug 7, 2018
@macedo22 macedo22 deleted the scatter-plots branch August 7, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants