Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This commit along with a minor change to glue (which I madea PR for) … #92

Merged
merged 2 commits into from
Jul 31, 2018
Merged

This commit along with a minor change to glue (which I madea PR for) … #92

merged 2 commits into from
Jul 31, 2018

Conversation

scottcoughlin2014
Copy link
Contributor

…allow this to be run in py35

@coveralls
Copy link

coveralls commented Jul 30, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 240

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.372%
Totals Coverage Status
Change from base Build 235: 0.0%
Covered Lines: 426
Relevant Lines: 1082
💛 - Coveralls

@alurban alurban self-assigned this Jul 31, 2018
@alurban
Copy link
Member

alurban commented Jul 31, 2018

@scottcoughlin2014, does this PR require waiting for your other PR in glue to be merged, or is it ready right now?

duncanmmacleod
duncanmmacleod reviewed Jul 31, 2018
View reviewed changes
bin/gwdetchar-omega Outdated
try:
from StringIO import StringIO
except ImportError:
from io import StringIO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scottcoughlin2014 (@alurban) can we swap the ordering of this to make it python3-first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@scottcoughlin2014
Copy link
Contributor Author

@alurban Sure this can be merged without the glue merge. all it means is that it will still not work in python 3 until that is merged but not that this will all of a sudden stop working or whatever.

@alurban
Copy link
Member

alurban commented Jul 31, 2018

Ok, I will merge. Thanks @scottcoughlin2014 for putting this together and @duncanmmacleod for reviewing

@alurban alurban merged commit f517b10 into gwdetchar:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanmmacleod duncanmmacleod duncanmmacleod approved these changes

Assignees

@alurban alurban

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@scottcoughlin2014 @coveralls @alurban @duncanmmacleod