You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates any and all problems I could find related to python3 compatibility. The changes are fairly well separated into commits that touch one aspect of compatibility, so should be easy enough to review.
This should mean that the unit tests all run on python3, so I want to promote the travis-ci python3 jobs to a 'must pass'.
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me and pipelines are passing, I'm going to merge. One small comment in gwdetchar/omega/html.py, on the old line 31: this import of pytz.timezone was meant to allow you to write the detector's local timezone in the analysis summary (along with UTC), but I never got that to work properly, and I guess I forgot to remove unused imports.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates any and all problems I could find related to python3 compatibility. The changes are fairly well separated into commits that touch one aspect of compatibility, so should be easy enough to review.
This should mean that the unit tests all run on python3, so I want to promote the travis-ci python3 jobs to a 'must pass'.
cc: @alurban, @macedo22