Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of event caches #120

Merged
merged 3 commits into from
Mar 30, 2019
Merged

Fix handling of event caches #120

merged 3 commits into from
Mar 30, 2019

Conversation

alurban
Copy link
Member

@alurban alurban commented Mar 30, 2019 •
edited
Loading

This PR implements a fix to hveto's handling of event caches:

  • Since gwpy.io.cache.read_cache expects a single file (and not a list of files), require the user to pass only one --primary-cache and one --auxiliary-cache
  • Since hveto-cache-events now caches triggers to HDF5 files, but (as far as I'm aware) online Omicron still writes in ligolw format, unset the format keyword argument before reading from cached trigger files so that the format can be auto-detected
  • Misc. bugfixes for hveto-cache-events

This fixes #119.

cc @duncanmmacleod, @jrsmith02, @young-min

@alurban alurban added this to the 0.3.0 milestone Mar 30, 2019
@alurban alurban mentioned this pull request Mar 30, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.717% when pulling 198d943 on alurban:cache into 1f8dcdb on gwdetchar:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.717% when pulling 198d943 on alurban:cache into 1f8dcdb on gwdetchar:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.717% when pulling 198d943 on alurban:cache into 1f8dcdb on gwdetchar:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.717% when pulling 198d943 on alurban:cache into 1f8dcdb on gwdetchar:master.

@coveralls
Copy link

coveralls commented Mar 30, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 54.717% when pulling 4deccac on alurban:cache into 1f8dcdb on gwdetchar:master.

@jrsmith02 jrsmith02 merged commit c761c00 into gwdetchar:master Mar 30, 2019
@alurban alurban deleted the cache branch March 30, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jrsmith02 jrsmith02

Labels
bug-fix
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Errors on reading cache files
3 participants
@alurban @coveralls @jrsmith02