Add support for negative duration values in ISO8601 period parsing #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvlaming
reviewed
Jul 19, 2019
| r"(?P<days>-?[0-9]+([,.][0-9]+)?D)?" | ||
| r"((?P<separator>T)(?P<hours>-?[0-9]+([,.][0-9]+)?H)?" | ||
| r"(?P<minutes>-?[0-9]+([,.][0-9]+)?M)?" | ||
| r"(?P<seconds>-?[0-9]+([,.][0-9]+)?S)?)?$") | ||
| # regular expression to parse ISO duartion strings. |
Stephan202
approved these changes
Jul 19, 2019
bvlaming
approved these changes
Jul 19, 2019
|
Closing this as this module seems unmaintained, and reportedly does not function in Python 3.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41.
We are using a mixed Java/Python stack, and would benefit from the addition of support for negative duration values in the ISO8601 period parsing. For example,
PT6H-30Mwould correspond to a duration of05:30:00.As mentioned in #41, there is a precedent for supporting this format, looking for instance at MomentJS (moment/moment#2955).