Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove refresh_all in Windows on settings change. Fixes Issue #15 #16

Merged
merged 4 commits into from
Nov 8, 2019
Merged

Remove refresh_all in Windows on settings change. Fixes Issue #15 #16

merged 4 commits into from
Nov 8, 2019

Conversation

robertcollier4
Copy link
Contributor

As per bahanou suggestion at #15 (comment)

@robertcollier4 robertcollier4 changed the title Remove repeated calls to refresh_all in Windows on settings change. Fixes Issue #15 Remove refresh_all in Windows on settings change. Fixes Issue #15 Sep 4, 2019
@bahanonu
Copy link

bahanonu commented Sep 5, 2019

@robertcollier4

Still getting ST crashes on load (Windows 10, ST build 3207). If you comment out the below lines, works fine for me both for loading ST and for switching SetWindowTitle while ST is loaded. Else let me know if you want me to commit directly to the pull request; though doesn't appear I have permission. Will see if can figure out a fix to do what we want without crashing ST on Windows.

https://github.com/robertcollier4/SublimeSetWindowTitle/blob/master/set_window_title.py#L64-L65

  elif PLATFORM == "windows":
    SetWindowTitle().run(sublime.active_window().active_view())

@robertcollier4
Copy link
Contributor Author

All changes incorporated. Ready for commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants