Add a way to cleanup Allocator without dropping it. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
force-pushed
the
cleanup-without-drop
branch
from
d4856f9
to
8b57b15
Compare
Perhaps not very Rusty, but what VK use is? I need to destroy the allocator contents before I destroy the device, and it just gets really awkward to put the allocator in an Option<> and set it to None before destroy_device. This works around that.
hrydgard
force-pushed
the
cleanup-without-drop
branch
from
8b57b15
to
7b1d7b7
Compare
|
@gwihlidal fixed the build error, care to have a look? :) |
|
Looks good! Thanks. I'll push a new version asap |
|
Would it make sense to rename this to |
|
Much appreciated! I don't really care what it's named, up to Graham :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps not very Rusty, but what VK use is?
I need to destroy the allocator contents before I destroy the device, and it just gets really awkward to put the allocator in an Option<> and set it to None before destroy_device. This works around that.
I would also be open to other ideas, of course, if this isn't palatable.