Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mem::zeroed() in AllocatorCreateInfo::default() #39

Merged
merged 3 commits into from Oct 20, 2020

Conversation

aloucks
Copy link
Contributor

@aloucks aloucks commented Sep 30, 2020

Fixes an issue when compiling with Rust nightly. Calling AllocatorCreateInfo::default() results in:

panicked at 'attempted to zero-initialize type `ash::Device`, which is invalid

Fixes #19

Nightly rust has now turned the mem::zeroed warning into a runtime
panic.

Fixes gwihlidal#19
The old one is no longer present in newer Vulkan SDKs.
@aloucks
Copy link
Contributor Author

aloucks commented Oct 11, 2020

Hi @gwihlidal, would you be able to review? When the current Rust beta is promoted to stable, AllocatorCreateInfo::default() will always panic.

@hrydgard
Copy link
Contributor

We're also looking forward to getting this merged.

@gwihlidal gwihlidal merged commit a65fbe6 into gwihlidal:master Oct 20, 2020
@hrydgard
Copy link
Contributor

A new release would be great so we don't need to point to a specific git-hash version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from mem::zeroed to MaybeUninit<T>
3 participants