Add groundwater transport capabilities to nlmod #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add auxiliary variable support to GHB and CHD - add BUY package
- add GWT - add DIS (copy of GWF, dis, could be more efficient?) - add DISV (copy of GWT disv, could be more efficient) - add ADV - add DSP (determine where to pick up vars) - add SSM - add MST - add CNC - add OC (_set_record could be generalized between gwf/gwt) - add IC - add GWFGWT exchange
- add GWT - add DIS (copy of GWF, dis, could be more efficient?) - add DISV (copy of GWT disv, could be more efficient) - add ADV - add DSP (determine where to pick up vars) - add SSM - add MST - add CNC - add OC (_set_record could be generalized between gwf/gwt) - add IC - add GWFGWT exchange
- allow aux to be both dataset variable (str) and single float/int
- weighted mean value of source dataarray per layer defined in model dataset
- make dis/disv work for both gwf and gwt - improve aux support to ghb/chd - store ssm_sources if aux is defined and transport is True - add drn package, similar to GHB - make _set_record work for both head and concentration for oc pkg
- allow masking where recharge should be applied.
- reuse gwf dis/disv and _set_record - improve getting vars from dataset or passing directly to function - for ssm, get sources from ssm_sources attribute (auto added when gwf pkgs are created with aux vars)
- add method to load concentrations as dataarray - add method to get concentrations at gw surface (first active layer)
- supports chloride (with certain default values)
- no overwriting stored dataset attributes when building a model - introduce _get_var_from_ds_attr for unifying method to obtain attribute data from dataset - introduce _get_var_from_ds_datavar for unifying method to obtain data variable from dataset - allow setting custom modelname for transport model - add docstrings
OnnoEbbens
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces functionality to create a transport model using
nlmod.lrc_to_reclistandlcid_to_reclistto accept aux varsaggregate_by_weighted_mean_to_dsto vertically calculate the weighted mean per layer from a dataset with different layer definition.