Added get_exe_path with more features #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use previously installed anywhere. If doesn't exist, download it.
|
As I am switching a lot between different Python environments and recreating them, the implemented features greatly reduce the number of having to download the executables. |
|
There are two minor remarks on the coding style from codacy, and I don't see easy fixes for those. The try/except should catch multiple errors (haven't encountered all of them) and the other one I don't understand. |
|
The tests failing are not related to this PR. They were also failing in the previous commit: #345 |
dbrakenhoff
reviewed
May 24, 2024
dbrakenhoff
reviewed
May 24, 2024
dbrakenhoff
reviewed
May 24, 2024
dbrakenhoff
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use previously installed anywhere. If doesn't exist, download it.