GROUNDWORK-2996 cleanup connectors #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymkins
force-pushed
the
GROUNDWORK-2996_cleanup_connectors
branch
2 times, most recently
from
9c4697d
to
16391ac
Compare
added 8 commits
May 14, 2024 20:25
https://golangci-lint.run/product/changelog/#v1581 log an error when using previously deprecated linters https://golangci-lint.run/product/changelog/#v1490 varcheck: This linter is deprecated use unused instead. deadcode: This linter is deprecated use unused instead. structcheck: This linter is deprecated use unused instead.
There is buitin since go1.21 https://pkg.go.dev/builtin@go1.21.0#min
As we no more plan to remove such functionality
ymkins
force-pushed
the
GROUNDWORK-2996_cleanup_connectors
branch
from
16391ac
to
72430a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.