Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROUNDWORK-3105 Handle oversized payload #349

Merged
merged 4 commits into from
May 31, 2024

Conversation

ymkins
Copy link
Contributor

@ymkins ymkins commented May 14, 2024

It addresses the issue caused by reaching 8MB limit for size of the message stored in Nats queue.
It's a rare case on huge inventory only.

We handle oversized payloads on quieing in a few steps:

  • Compressing oversized payloads with GZIP before processing in qieue. Then sending gzip-compressed payloads on HTTP as we already support it.
  • And huge payload that oversizes 8MB limit after compression processed in queue as a placeholder instead of data and stored as file.

@ymkins ymkins force-pushed the GROUNDWORK-3105_oversized_payload branch 2 times, most recently from 35eba7e to d7450b1 Compare May 21, 2024 21:19
@ymkins ymkins force-pushed the GROUNDWORK-3105_oversized_payload branch 2 times, most recently from 26b6053 to deb5ac3 Compare May 22, 2024 17:51
@ymkins ymkins force-pushed the GROUNDWORK-3105_oversized_payload branch 7 times, most recently from 66bf309 to 56a2d92 Compare May 27, 2024 18:47
@ymkins ymkins force-pushed the GROUNDWORK-3105_oversized_payload branch from 56a2d92 to d3e2cc3 Compare May 27, 2024 20:21
@ymkins ymkins marked this pull request as ready for review May 28, 2024 13:25
@saurabhgovindlonkar saurabhgovindlonkar merged commit 6186498 into master May 31, 2024
4 checks passed
@ymkins ymkins deleted the GROUNDWORK-3105_oversized_payload branch May 31, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants