Improved handling of Omicron parameters files #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use `parameters.OmicronParameters` object - all nodes in workflow are now repeatable, except the rm node which is now the final step in the workflow - all nodes register input and output files (has no impact except in comments in the condor files)
duncanmmacleod
added
omicron.condor
these are now instances methods of `OmicronParameters`
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-works the
omicron-processexecutable and theomicron.parametersmodule to better handle Omicron parameters files. PyOmicron now uses a sub-class ofConfigParserto handle these files, with custom I/O methods to match the ASCII format for these files.This PR also improves the workflow in a few ways.