Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved frameCPP import into function #60

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Moved frameCPP import into function #60

merged 1 commit into from
Mar 8, 2018

Conversation

duncanmmacleod
Copy link
Member

This PR moves the frameCPP import (used to determine only whether it is present, and isn't actually used) into the method where it is used. This works around a segfault in LDAStools.frameCPP somewhere.

@duncanmmacleod
segments: moved frameCPP import
77620e4 
resolves segfault somehow
@duncanmmacleod duncanmmacleod added this to the 0.5.1 milestone Mar 8, 2018
@duncanmmacleod duncanmmacleod self-assigned this Mar 8, 2018
@coveralls
Copy link

coveralls commented Mar 8, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 47.524% when pulling 77620e4 on duncanmmacleod:framecpp-import into 989f812 on ligovirgo:master.

@duncanmmacleod duncanmmacleod merged commit 13c1ebb into gwpy:master Mar 8, 2018
@duncanmmacleod duncanmmacleod deleted the framecpp-import branch March 8, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@duncanmmacleod duncanmmacleod

Labels
None yet
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@duncanmmacleod @coveralls