This repository has been archived by the owner on Apr 2, 2019. It is now read-only.
Introduce isPast(), isFuture() and isInfinite() on DateRanges and DateTimeRanges #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function isInfinite() | ||
| { | ||
| return self::infinite() == $this; |
There was a problem hiding this comment.
I think this should be static:: instead of self::, in case infinite() is overridden by a subclass. It's also consistent with the isFuture() and isPast().
|
Thank you! If you want to resolve that small change I suggested and rebase I can merge this. |
|
How do you rebase in github? |
|
@rquadling Hmm, I just meant to squash the commit. You can squash commits interactively using
https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/ |
…eTimeRanges Allow users to determine if a date/datetime range is anchored in the past, the future or both.
|
Tada! |
|
Thank you, and I've released v0.4.0 with these changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to determine if a date/datetime range is anchored in the past, the future or both.